On Fri, 30 Apr 2021, Xin Long wrote:

Currently when processing a duplicate COOKIE-ECHO chunk, a new temp
asoc would be created, then it creates the chunks with the new asoc.
However, later on it uses the old asoc to send these chunks, which
has caused quite a few issues.

This patchset is to fix this and make sure that the COOKIE-ACK and
SHUTDOWN chunks are created with the same asoc that will be used to
send them out.

Again, much thanks for looking into this. Patches 1 and 3 are
almost the same as my patch, which as I mentioned I've been
testing on and off for the past couple of weeks, and haven't
found any problems. (Then again, I didn't find any problems last
time either.)

I think 145cb2f7177d ("sctp: Fix bundling of SHUTDOWN with
COOKIE-ACK") should not be reverted (I'll reply to the patch).

12dfd78e3a74 ("sctp: Fix SHUTDOWN CTSN Ack in the peer restart
case") should be reverted. With association update no longer a
side effect, we can get CTSN normally from current assoc, since
it has been updated before sctp_make_shutdown().

v1->v2:
 - see Patch 3/3.

Xin Long (3):
 sctp: do asoc update earlier in sctp_sf_do_dupcook_a
 Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK"
 sctp: do asoc update earlier in sctp_sf_do_dupcook_b

include/net/sctp/command.h |  1 -
net/sctp/sm_sideeffect.c   | 26 ------------------------
net/sctp/sm_statefuns.c    | 50 ++++++++++++++++++++++++++++++++++++----------
3 files changed, 39 insertions(+), 38 deletions(-)

--
2.1.0