Thread (4 messages) 4 messages, 4 authors, 2021-04-22

Re: [PATCH v2][next] wireless: wext-spy: Fix out-of-bounds warning

From: Kees Cook <hidden>
Date: 2021-04-22 20:48:54
Also in: linux-hardening, linux-wireless, lkml

On Thu, Apr 22, 2021 at 10:04:29PM +0200, Johannes Berg wrote:
On Thu, 2021-04-22 at 15:00 -0500, Gustavo A. R. Silva wrote:
quoted
Changes in v2:
 - Use direct struct assignments instead of memcpy().
 - Fix one more instance of this same issue in function
   iw_handler_get_thrspy().
 - Update changelog text.
Thanks.
quoted
 - Add Kees' RB tag. 
He probably won't mind in this case, but you did some pretty substantial
changes to the patch, so I really wouldn't recommend keeping it there.
Thanks for double-checking! Yeah, I'm fine with it; Gustavo and I had
talked in the past about similar solutions in other places, so he
forwarded the intent from those conversations. (Not that you had any
visibility into that!) But, yes, still:

Reviewed-by: Kees Cook <redacted>

Thanks!

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help