RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Salil Mehta
Sent: Tuesday, April 13, 2021 3:45 PM
To: davem@davemloft.net; kuba@kernel.org
Cc: salil.mehta@huawei.com; linuxarm@openeuler.org;
netdev@vger.kernel.org; linuxarm@huawei.com; linux-
kernel@vger.kernel.org; Jeff Kirsher [off-list ref]; intel-
wired-lan@lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R,
T}XQ check/code for efficiency+readability

If user has explicitly requested the number of {R,T}XQs, then it is
unnecessary to get the count of already available {R,T}XQs from the PF
avail_{r,t}xqs bitmap. This value will get overridden by user specified value in
any case.

This patch does minor re-organization of the code for improving the flow and
readabiltiy. This scope of improvement was found during the review of the
ICE driver code.

FYI, I could not test this change due to unavailability of the hardware.
It would be helpful if somebody can test this patch and provide Tested-by
Tag. Many thanks!

Fixes: 87324e747fde ("ice: Implement ethtool ops for channels")
Cc: intel-wired-lan@lists.osuosl.org
Cc: Jeff Kirsher <redacted>
Signed-off-by: Salil Mehta <redacted>
--
Change V1->V2
 (*) Fixed the comments from Anthony Nguyen(Intel)
     Link: https://lkml.org/lkml/2021/4/12/1997
---
 drivers/net/ethernet/intel/ice/ice_lib.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Tested-by: Tony Brelinski <redacted> (A Contingent Worker at Intel)