Re: [PATCH RESEND][next] net/packet: Fix fall-through warnings for Clang
From: Gustavo A. R. Silva <hidden>
Date: 2021-04-20 20:11:02
Also in:
linux-hardening, lkml
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:44, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- net/packet/af_packet.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index e24b2841c643..880a1ab9a305 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c@@ -1652,6 +1652,7 @@ static int fanout_add(struct sock *sk, struct fanout_args *args) case PACKET_FANOUT_ROLLOVER: if (type_flags & PACKET_FANOUT_FLAG_ROLLOVER) return -EINVAL; + break; case PACKET_FANOUT_HASH: case PACKET_FANOUT_LB: case PACKET_FANOUT_CPU: