Re: [PATCH] brcmsmac: fix shift on 4 bit masked value
From: Kalle Valo <hidden>
Date: 2021-04-18 06:10:37
Also in:
kernel-janitors, linux-wireless, lkml
Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>
The calculation of offtune_val seems incorrect, the u16 value in
pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then
shifted 8 places right so that always ends up as a zero result. I
believe the intended shift was 4 bits to the right. Fix this.
[Note: not tested, I don't have the H/W]
Addresses-Coverity: ("Operands don't affect result")
Fixes: 5b435de0d786 ("net: wireless: add brcm80211 drivers")
Signed-off-by: Colin Ian King <redacted>I think this needs review from someone familiar with the hardware. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210318164513.19600-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches