Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-04-13 13:51:29
Also in:
linux-rdma, lkml
On Tue, Apr 13, 2021 at 09:29:41AM +0300, Leon Romanovsky wrote:
On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote:quoted
On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote:quoted
ib_modify_qp() is an expensive operation on some HCAs running virtualized. This series removes two ib_modify_qp() calls from RDS. I am sending this as a v3, even though it is the first sent to net. This because the IB Core commit has reach v3. Håkon Bugge (2): IB/cma: Introduce rdma_set_min_rnr_timer() rds: ib: Remove two ib_modify_qp() callsApplied to rdma for-next, thanksJason, It should be + WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_TGT); and not + if (WARN_ON(id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_TGT)) + return -EINVAL;
Unless we can completely remove the return code the if statement is a reasonable way to use the WARN_ON here Jason