Re: [igb] netconsole triggers warning in netpoll_poll_dev
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-04-07 15:37:53
Also in:
intel-wired-lan, lkml
Subsystem:
intel ethernet drivers, networking drivers, the rest · Maintainers:
Tony Nguyen, Przemek Kitszel, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote:
Thanks for the effort, but reportedly [1] it made no difference, unfortunately. [1] https://bugzilla.kernel.org/show_bug.cgi?id=212573#c8
The only other option I see is that somehow the NAPI has no rings.
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index a45cd2b416c8..24568adc2fb1 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c@@ -7980,7 +7980,7 @@ static int igb_poll(struct napi_struct *napi, int budget) struct igb_q_vector *q_vector = container_of(napi, struct igb_q_vector, napi); - bool clean_complete = true; + bool clean_complete = q_vector->tx.ring || q_vector->rx.ring; int work_done = 0; #ifdef CONFIG_IGB_DCA