Re: [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK processing

On Tue, Apr 06, 2021 at 07:26:29PM +0200, Eric Dumazet wrote:

On 4/5/21 1:35 PM, Phillip Potter wrote:

quoted

When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len
to match the appropriate type, using new tun_get_addr_len utility function
which returns appropriate address length for given type. Fixes a
KMSAN-found uninit-value bug reported by syzbot at:
https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51

Reported-by: syzbot+001516d86dbe88862cec@syzkaller.appspotmail.com
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---

Please give credits to people who helped.

You could have :

Suggested-by: Eric Dumazet <edumazet@google.com>

Or
Diagnosed-by: Eric Dumazet [off-list ref]

Or at least CCed me :/

Dear Eric,

Please accept my apology for this oversight. It certainly wasn't
intentional on my part, and entirely down to inexperience. I will send
the patch again with Diagnosed-by.

Regards,
Phil