Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features_check().
From: Michael Chan <michael.chan@broadcom.com>
Date: 2021-04-26 17:53:01
Attachments
- smime.p7s [application/pkcs7-signature] 4209 bytes
From: Michael Chan <michael.chan@broadcom.com>
Date: 2021-04-26 17:53:01
On Mon, Apr 26, 2021 at 10:36 AM Jakub Kicinski [off-list ref] wrote:
On Mon, 26 Apr 2021 10:09:29 -0700 Michael Chan wrote:quoted
On Mon, Apr 26, 2021 at 10:00 AM Jakub Kicinski [off-list ref] wrote:quoted
On Mon, 26 Apr 2021 09:45:17 -0700 Michael Chan wrote:quoted
Sorry, hit send too early. If it is not UDP, it could be GRE or IP over IP for example, right? Why do we need to turn off offload?All supported protocols can be included in the allow list. That's one of the costs of NETIF_F_IP_CSUM, the driver needs to make sure the device can understand the packet.Only UDP encapsulations have the 2 port limitations. The rest are supported.AFAIU you claim that other than certain UDP formats your device can parse _every_ possible packet encapsulation. To which I have no reply.
Fair enough. I'll get the list of supported encapsulations and check for all supported types.