Re: [PATCH net-next 3/3] net: update netdev_rx_csum_fault() print dump only once

From
Yunsheng Lin <hidden>
Date
2021-04-23 00:42:51
Reply to
Tanner Love, 2021-04-22
On 2021/4/23 3:47, Tanner Love wrote:
quoted hunk ↗ jump to hunk
From: Tanner Love <redacted>

Printing this stack dump multiple times does not provide additional
useful information, and consumes time in the data path. Printing once
is sufficient.

Signed-off-by: Tanner Love <redacted>
Acked-by: Eric Dumazet <redacted>
Acked-by: Mahesh Bandewar <redacted>
---
 net/core/dev.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index d9bf63dbe4fd..26b82b5d8563 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -148,6 +148,7 @@
 #include <net/devlink.h>
 #include <linux/pm_runtime.h>
 #include <linux/prandom.h>
+#include <linux/once.h>
 
 #include "net-sysfs.h"
 
@@ -3487,13 +3488,16 @@ EXPORT_SYMBOL(__skb_gso_segment);
 
 /* Take action when hardware reception checksum errors are detected. */
 #ifdef CONFIG_BUG
-void netdev_rx_csum_fault(struct net_device *dev, struct sk_buff *skb)
+static void do_netdev_rx_csum_fault(struct net_device *dev, struct sk_buff *skb)
 {
-	if (net_ratelimit()) {
 		pr_err("%s: hw csum failure\n", dev ? dev->name : "<unknown>");
 		skb_dump(KERN_ERR, skb, true);
 		dump_stack();
Once the "if ()" is removed, one level of indent seems enough?
quoted hunk ↗ jump to hunk
-	}
+}
+
+void netdev_rx_csum_fault(struct net_device *dev, struct sk_buff *skb)
+{
+	DO_ONCE_LITE(do_netdev_rx_csum_fault, dev, skb);
 }
 EXPORT_SYMBOL(netdev_rx_csum_fault);
 #endif
  
Thread (8 messages) 8 messages, 3 authors, last reply 2021-04-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help