Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote:

On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote:

quoted

On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:

quoted

On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:  

quoted

On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:    

FWIW ethnl_parse_bit() -> ETHTOOL_A_BITSET_BIT_NAME
User space can also use raw flags like --groups 0xf but that's perhaps
too spartan for serious use.    

So the kernel can work with ETHTOOL_A_BITSET_BIT_INDEX /
ETHTOOL_A_BITSET_BIT_NAME, but I was wondering if using ethtool binary
we can query the strings that the kernel will accept. I think not?  

Heh, I misunderstood your question. You're asking if the strings can be
queried from the command line.

No, I don't think so. We could add some form of "porcelain" command if
needed.

We don't have such command but I think it would be useful. After all, as
you pointed out, the request is already implemented at UAPI level so all
we need is to make it available to user.

The syntax will be a bit tricky as some string sets are global and some
per device. Out of

    ethtool --show-strings [devname] <setname>
    ethtool --show-strings [devname] set <setname>
    ethtool --show-strings <setname> [dev <devname>]

the third seems nicest but also least consistent with the rest of
ethtool command line syntax. So probably one of the first two.

Michal