Thread (3 messages) flat view 3 messages, 3 authors, 2021-04-12

Re: [PATCH] vdpa/mlx5: Set err = -ENOMEM in case dma_map_sg_attrs fails

From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2021-04-12 12:49:44
Also in: virtualization

On Sun, Apr 11, 2021 at 11:36:46AM +0300, Eli Cohen wrote:
quoted hunk ↗ jump to hunk
Set err = -ENOMEM if dma_map_sg_attrs() fails so the function reutrns
error.

Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
Signed-off-by: Eli Cohen <redacted>
Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
---
drivers/vdpa/mlx5/core/mr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/core/mr.c b/drivers/vdpa/mlx5/core/mr.c
index 3908ff28eec0..800cfd1967ad 100644
--- a/drivers/vdpa/mlx5/core/mr.c
+++ b/drivers/vdpa/mlx5/core/mr.c
@@ -278,8 +278,10 @@ static int map_direct_mr(struct mlx5_vdpa_dev *mvdev, struct mlx5_vdpa_direct_mr
	mr->log_size = log_entity_size;
	mr->nsg = nsg;
	mr->nent = dma_map_sg_attrs(dma, mr->sg_head.sgl, mr->nsg, DMA_BIDIRECTIONAL, 0);
-	if (!mr->nent)
+	if (!mr->nent) {
+		err = -ENOMEM;
		goto err_map;
+	}

	err = create_direct_mr(mvdev, mr);
	if (err)
-- 
2.30.1
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help