Re: [PATCH net v2 2/3] net: sched: fix action overwrite reference counting

From
Jamal Hadi Salim <jhs@mojatatu.com>
Date
2021-04-08 13:43:31
Reply to
Vlad Buslov, 2021-04-08
On 2021-04-08 3:50 a.m., Vlad Buslov wrote:
On Thu 08 Apr 2021 at 02:50, Cong Wang [off-list ref] wrote:
Origins of setting ovr based on NLM_F_REPLACE are lost since this code
goes back to Linus' Linux-2.6.12-rc2 commit. Jamal, do you know if this
is the expected behavior or just something unintended?
Seems our emails crossed path. The problem with ovr is the ambiguity
of whether we are saying both CREATE and REPLACE or just one or the
other. We could improve the kernel side by just passing the flags
to each action. Note it is too late to fix iproute2 without some
backward compat flag; but it may not be too late for someone writting
a new application in user space.

cheers,
jamal
Thread (11 messages) 11 messages, 3 authors, last reply 2021-04-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help