Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c
flat view
From: Greg KH <hidden>
Date: 2021-03-25 15:12:39
Also in:
kernel-janitors, linux-usb
On Thu, Mar 25, 2021 at 10:56:52PM +0800, 'Qiheng Lin wrote:
quoted hunk ↗ jump to hunk
From: Qiheng Lin <redacted> Remove duplicated include. Reported-by: Hulk Robot <redacted> Signed-off-by: Qiheng Lin <redacted> --- drivers/net/usb/pegasus.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 9a907182569c..e0ee5c096396 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c@@ -65,7 +65,6 @@ static struct usb_eth_dev usb_dev_id[] = { {.name = pn, .vendor = vid, .device = pid, .private = flags}, #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \ PEGASUS_DEV(pn, vid, pid, flags) -#include "pegasus.h" #undef PEGASUS_DEV #undef PEGASUS_DEV_CLASS {NULL, 0, 0, 0},@@ -84,7 +83,6 @@ static struct usb_device_id pegasus_ids[] = { #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \ {.match_flags = (USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_DEV_CLASS), \ .idVendor = vid, .idProduct = pid, .bDeviceClass = dclass}, -#include "pegasus.h" #undef PEGASUS_DEV #undef PEGASUS_DEV_CLASS {},
Did you build and test this code now with this change? I think you broke this driver badly now :( Please think about _why_ the code would have been written this way in the first place, it is a bit odd, right? netdev maintainers, consider this a NAK. thanks, greg k-h