Thread (6 messages) flat view 6 messages, 3 authors, 2021-03-31

Re: [PATCH v4 0/3] PCI: Disable parity checking

From: Krzysztof Wilczyński <hidden>
Date: 2021-03-31 11:27:59
Also in: linux-arm-kernel, linux-pci

Hi Bjorn,
I think this is essentially the same as Heiner's v3 posting, with these
changes:

  - Added a pci_disable_parity() interface in pci.c instead of making a
    public pci_quirk_broken_parity() because quirks.c is only compiled when
    CONFIG_PCI_QUIRKS=y.
Very nice idea to add pci_disable_parity(), looks very clean.
  - Removed the setting of dev->broken_parity_status because it's really
    only used by EDAC error reporting, and if we disable parity error
    reporting, we shouldn't get there.  This change will be visible in the
    sysfs "broken_parity_status" file, but I doubt that's important.

I dropped Leon's reviewed-by because I fiddled with the code.  Similarly I
haven't added your signed-off-by, Heiner, because I don't want you blamed
for my errors.  But if this looks OK to you I'll add it.
[...]


Thank you Bjorn and Heiner!

Reviewed-by: Krzysztof Wilczyński <redacted>

Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help