Re: [PATCH net-next] net: stmmac: fix missing unlock on error in stmmac_suspend()

On Tue, Mar 16, 2021 at 7:50 AM Edmundo Carmona Antoranz
[off-list ref] wrote:

I think you can let it go and check ret after unlocking:

                /* Disable clock in case of PWM is off */
               clk_disable_unprepare(priv->plat->clk_ptp_ref);
               ret = pm_runtime_force_suspend(dev);
       }
       mutex_unlock(&priv->lock);
       if (ret)
               return ret;

Oh, I C. It would require ret to be set to 0 before starting to use
it, right? Maybe it's worth it?

       priv->speed = SPEED_UNKNOWN;
       return 0;