Thread (51 messages) 51 messages, 3 authors, 2021-04-01

Re: [PATCH 11/18] iommu/fsl_pamu: remove the snoop_id field

From: Will Deacon <will@kernel.org>
Date: 2021-03-30 12:59:20
Also in: dri-devel, kvm, linux-arm-kernel, linux-arm-msm, linux-iommu, linuxppc-dev, virtualization

On Tue, Mar 16, 2021 at 04:38:17PM +0100, Christoph Hellwig wrote:
The snoop_id is always set to ~(u32)0.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Li Yang <redacted>
---
 drivers/iommu/fsl_pamu_domain.c | 5 ++---
 drivers/iommu/fsl_pamu_domain.h | 1 -
 2 files changed, 2 insertions(+), 4 deletions(-)
pamu_config_ppaace() takes quite a few useless parameters at this stage,
but anyway:

Acked-by: Will Deacon <will@kernel.org>

Do you know if this driver is actually useful? Once the complexity has been
stripped back, the stubs and default values really stand out.

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help