RE: [Intel-wired-lan] [PATCH intel-net 2/3] ice: move headroom initialization to ice_setup_rx_ctx

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Maciej Fijalkowski
Sent: Wednesday, March 3, 2021 9:09 PM
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org; brouer@redhat.com; kuba@kernel.org;
bpf@vger.kernel.org; Topel, Bjorn [off-list ref]; Karlsson,
Magnus [off-list ref]
Subject: [Intel-wired-lan] [PATCH intel-net 2/3] ice: move headroom
initialization to ice_setup_rx_ctx

ice_rx_offset(), that is supposed to initialize the Rx buffer headroom, relies
on ICE_RX_FLAGS_RING_BUILD_SKB flag as well as XDP prog presence.

Currently, the callsite of mentioned function is placed incorrectly within
ice_setup_rx_ring() where Rx ring's build skb flag is not set yet. This causes
the XDP_REDIRECT to be partially broken due to inability to create xdp_frame
in the headroom space, as the headroom is 0.

Fix this by moving ice_rx_offset() to ice_setup_rx_ctx() after the flag setting.

Fixes: f1b1f409bf79 ("ice: store the result of ice_rx_offset() onto ice_ring")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_base.c | 18 ++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_txrx.c | 17 -----------------
 2 files changed, 18 insertions(+), 17 deletions(-)

Tested-by: Kiran Bhandare <redacted>  A Contingent Worker at Intel