Thread (3 messages) 3 messages, 3 authors, 2021-04-09

Re: [Intel-wired-lan] [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback test

From: Björn Töpel <hidden>
Date: 2021-03-09 07:30:40
Also in: bpf, intel-wired-lan

On Mon, 8 Mar 2021 at 21:42, Alexander Duyck [off-list ref] wrote:
From: Alexander Duyck <alexanderduyck@fb.com>

The ixgbe driver currently generates a NULL pointer dereference when
performing the ethtool loopback test. This is due to the fact that there
isn't a q_vector associated with the test ring when it is setup as
interrupts are not normally added to the test rings.

To address this I have added code that will check for a q_vector before
returning a napi_id value. If a q_vector is not present it will return a
value of 0.

Fixes: b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")
Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
Thanks Alex!

Acked-by: Björn Töpel <redacted>

I'll look into if this applies to the other Intel drivers as well.


Björn
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help