Thread (4 messages) flat view 4 messages, 4 authors, 2021-03-08

Re: [PATCHv2 bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

From: Naveen N . Rao <hidden>
Date: 2021-03-08 10:46:05
Also in: bpf

On 2021/03/05 02:40PM, Jiri Olsa wrote:
When testing uprobes we the test gets GEP (Global Entry Point)
address from kallsyms, but then the function is called locally
so the uprobe is not triggered.

Fixing this by adjusting the address to LEP (Local Entry Point)
for powerpc arch plus instruction check stolen from ppc_function_entry
function pointed out and explained by Michael and Naveen.

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Naveen N. Rao <redacted>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 .../selftests/bpf/prog_tests/attach_probe.c   | 40 ++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)
LGTM. FWIW:
Acked-by: Naveen N. Rao <redacted>

Thanks,
- Naveen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help