Thread (3 messages) 3 messages, 3 authors, 2021-03-05

Re: [PATCH bpf] veth: store queue_mapping independently of XDP prog presence

From: Toshiaki Makita <hidden>
Date: 2021-03-05 14:51:03
Also in: bpf

On 2021/03/04 0:29, Maciej Fijalkowski wrote:
Currently, veth_xmit() would call the skb_record_rx_queue() only when
there is XDP program loaded on peer interface in native mode.

If peer has XDP prog in generic mode, then netif_receive_generic_xdp()
has a call to netif_get_rxqueue(skb), so for multi-queue veth it will
not be possible to grab a correct rxq.

To fix that, store queue_mapping independently of XDP prog presence on
peer interface.

Fixes: 638264dc9022 ("veth: Support per queue XDP ring")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
I did like this in order to keep the default behavior for non-xdp case,
but generic XDP should behave the same as native XDP, so

Acked-by: Toshiaki Makita <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help