Thread (3 messages) flat view 3 messages, 2 authors, 2021-03-05

Re: [PATCH net] ethernet: alx: fix order of calls on resume

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-03-05 22:20:27
Also in: stable

On Fri,  5 Mar 2021 14:17:29 -0800 Jakub Kicinski wrote:
netif_device_attach() will unpause the queues so we can't call
it before __alx_open(). This went undetected until
commit b0999223f224 ("alx: add ability to allocate and free
alx_napi structures") but now if stack tries to xmit immediately
on resume before __alx_open() we'll crash on the NAPI being null:
Cc: <redacted> # 4.9+
Fixes: bc2bebe8de8e ("alx: remove WoL support")
Reported-by: Zbynek Michl <redacted>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983595
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
I should have also added:

Tested-by: Zbynek Michl <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help