Thread (2 messages) 2 messages, 2 authors, 2021-03-29

Re: [PATCH] net:tipc: Fix a double free in tipc_sk_mcast_rcv

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-29 23:30:46
Also in: lkml

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun, 28 Mar 2021 00:30:29 -0700 you wrote:
In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get
the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from arrvq
and returns the skb which equals to skb_peek(arrvq). After __skb_dequeue(arrvq)
finished, the skb is freed by kfree_skb(__skb_dequeue(arrvq)) in the first time.

Unfortunately, the same skb is freed in the second time by kfree_skb(skb) after
the branch completed.

[...]
Here is the summary with links:
  - net:tipc: Fix a double free in tipc_sk_mcast_rcv
    https://git.kernel.org/netdev/net/c/6bf24dc0cc0c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help