Re: [PATCH] octeontx2-af: Fix memory leak of object buf

From: Colin Ian King <redacted>

Currently the error return path when lfs fails to allocate is not free'ing
the memory allocated to buf. Fix this by adding the missing kfree.

Addresses-Coverity: ("Resource leak")
Fixes: f7884097141b ("octeontx2-af: Formatting debugfs entry rsrc_alloc.")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
index 8ec17ee72b5d..9bf8eaabf9ab 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c

@@ -253,8 +253,10 @@ static ssize_t rvu_dbg_rsrc_attach_status(struct file *filp,
                return -ENOSPC;

        lfs = kzalloc(lf_str_size, GFP_KERNEL);
-       if (!lfs)
+       if (!lfs) {
+               kfree(buf);
                return -ENOMEM;
+       }
        off +=  scnprintf(&buf[off], buf_size - 1 - off, "%-*s", lf_str_size,
                          "pcifunc");
        for (index = 0; index < BLK_COUNT; index++)
--

2.30.2