Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()

On 3/17/21 6:00 PM, Florian Fainelli wrote:

On 3/17/2021 3:49 PM, Alex Elder wrote:

quoted

On 3/17/21 5:47 PM, Florian Fainelli wrote:

quoted

quoted

+/* Encapsulate extracting high-order 32 bits of DMA address */
+static u32 dma_addr_high32(dma_addr_t addr)
+{
+#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
+    return (u32)(addr >> 32);

You can probably use upper_32bits() here...

Where is that defined?  I'd be glad to use it.    -Alex

include/linux/kernel.h, and it is upper_32_bits() and lower_32_bits()
sorry about the missing space.

That's nice.  I'll still use a separate commit (and will
credit you with the suggestion) but it will be much smaller.

Thanks.  I'll post v2 shortly.

					-Alex