Re: [PATCH net-next v2 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-03-17 20:56:34
Also in:
linux-arm-kernel, lkml
On Wed, 17 Mar 2021 09:01:23 +0800 Ong Boon Leong wrote:
Extending the driver to support per-queue RX and TX coalesce settings in
order to support below commands:
To show per-queue coalesce setting:-
$ ethtool --per-queue <DEVNAME> queue_mask <MASK> --show-coalesce
To set per-queue coalesce setting:-
$ ethtool --per-queue <DEVNAME> queue_mask <MASK> --coalesce \
[rx-usecs N] [rx-frames M] [tx-usecs P] [tx-frames Q]
Signed-off-by: Ong Boon Leong <redacted>Acked-by: Jakub Kicinski <kuba@kernel.org>
+ if (queue < tx_cnt) {
+ ec->tx_coalesce_usecs = priv->tx_coal_timer[queue];
+ ec->tx_max_coalesced_frames = priv->tx_coal_frames[queue];
+ } else {
+ ec->tx_coalesce_usecs = 0;
+ ec->tx_max_coalesced_frames = 0;nit: I think the struct is initialized to 0 so there is no need to set it explicitly.