Re: [net PATCH 1/9] octeontx2-pf: Do not modify number of rules
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-03-16 17:04:10
Also in:
lkml
On Tue, 16 Mar 2021 14:57:05 +0530 Hariprasad Kelam wrote:
From: Subbaraya Sundeep <sbhatta@marvell.com>
In the ETHTOOL_GRXCLSRLALL ioctl ethtool uses
below structure to read number of rules from the driver.
struct ethtool_rxnfc {
__u32 cmd;
__u32 flow_type;
__u64 data;
struct ethtool_rx_flow_spec fs;
union {
__u32 rule_cnt;
__u32 rss_context;
};
__u32 rule_locs[0];
};
Driver must not modify rule_cnt member. But currently driver
modifies it by modifying rss_context. Hence fix it by using a
local variable.
Fixes: 81a43620("octeontx2-pf: Add RSS multi group support")
Fixes tag: Fixes: 81a43620("octeontx2-pf: Add RSS multi group support")
Has these problem(s):
- missing space between the SHA1 and the subject
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Please fix the entire submission.