Re: [PATCH net-next 3/8] net: dsa: microchip: add DSA support for microchip lan937x

On Fri, 2021-02-05 at 14:27 +0100, Andrew Lunn wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you
know the content is safe

quoted

quoted

quoted

+bool lan937x_is_internal_tx_phy_port(struct ksz_device *dev,
int
port)
+{
+     /* Check if the port is internal tx phy port */

What is an internal TX phy port? Is it actually a conventional t2
Fast
Ethernet port, as opposed to a t1 port?

This is 100 Base-Tx phy which is compliant with
802.3/802.3u standards. Two of the SKUs have both T1 and TX
integrated
Phys as mentioned in the patch intro mail.

I don't think we have a good name for a conventional fast Ethernet.
But since we call the other T1, since it has a single pair, maybe use
T2, since Fast Ethernet uses 2 pair. I would also suggest a comment
near this code explaining what T1 and T2 mean.

This is compliant with 802.3u (100 Base-Tx) as i mentioned above. So
naming it as "T2" would not match. Can we name it as "100BTX" instead
of Tx? Thanks.