Re: [PATCH] net: mellanox: mlx5: fix error return code in mlx5_fpga_device_start()

On Sun, 2021-03-07 at 10:50 +0200, Leon Romanovsky wrote:

On Thu, Mar 04, 2021 at 06:18:14AM -0800, Jia-Ju Bai wrote:

quoted

When mlx5_is_fpga_lookaside() returns a non-zero value, no error
return code is assigned.
To fix this bug, err is assigned with -EINVAL as error return code.

Reported-by: TOTE Robot <redacted>
Signed-off-by: Jia-Ju Bai <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Like Heiner said, the current code has correct behavior.
The mlx5_fpga_device_load_check() has same mlx5_is_fpga_lookaside()
check and it is not an error if it returns true.

NAK: Leon Romanovsky [off-list ref]

Thanks

Agreed, apparently this robot is looking for "goto {out|*err*}"
statements and treats all of them as errors, this is very unreliable,