Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0
From: Yauheni Kaliuta <hidden>
Date: 2021-03-10 09:33:22
Also in:
bpf, linux-kselftest, lkml
On Wed, Mar 10, 2021 at 8:23 AM Jiapeng Chong [off-list ref] wrote:
Fix the following coccicheck warning: ./tools/testing/selftests/bpf/progs/test_global_func10.c:17:12-13: WARNING comparing pointer to 0.
but it's ok from the C standard point of view
quoted hunk ↗ jump to hunk
Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> --- tools/testing/selftests/bpf/progs/test_global_func10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/tools/testing/selftests/bpf/progs/test_global_func10.c b/tools/testing/selftests/bpf/progs/test_global_func10.c index 61c2ae9..97b7031 100644 --- a/tools/testing/selftests/bpf/progs/test_global_func10.c +++ b/tools/testing/selftests/bpf/progs/test_global_func10.c@@ -14,7 +14,7 @@ struct Big { __noinline int foo(const struct Big *big) { - if (big == 0) + if (!big) return 0; return bpf_get_prandom_u32() < big->y; --1.8.3.1
-- WBR, Yauheni