Thread (3 messages) 3 messages, 2 authors, 2021-03-09

Re: [PATCH] net: bridge: fix error return code of do_update_counters()

From: Jia-Ju Bai <hidden>
Date: 2021-03-09 13:32:46
Also in: bridge, lkml, netfilter-devel


On 2021/3/9 19:01, Florian Westphal wrote:
Jia-Ju Bai [off-list ref] wrote:
quoted
When find_table_lock() returns NULL to t, no error return code of
do_update_counters() is assigned.
Its -ENOENT.
quoted
  	t = find_table_lock(net, name, &ret, &ebt_mutex);
                                        ^^^^^

ret is passed to find_table_lock, which passes it to
find_inlist_lock_noload() which will set *ret = -ENOENT
for NULL case.
Thanks for the reply!
I did not notice "&ret" in find_table_lock()...
I am sorry for the false positive.


Best wishes,
Jia-Ju Bai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help