Re: [PATCH] net: netlink: fix error return code of netlink_proto_init()

On 2021/3/9 16:47, Heiner Kallweit wrote:

On 09.03.2021 09:33, Jia-Ju Bai wrote:

quoted

When kcalloc() returns NULL to nl_table, no error return code of
netlink_proto_init() is assigned.
To fix this bug, err is assigned with -ENOMEM in this case.

Didn't we talk enough about your incorrect patches yesterday?
This one is incorrect again. panic() never returns.
Stop sending patches until you understand the code you're changing!

Ah, sorry, I was too confident about this bug report...
Thanks for your reply.
Following your advice, now I am sending the patches only for the bug 
reports that I am confident about after careful code review.
Some of the patches have been applied, but some of them are still wrong, 
like this patch...
I am sorry for the false positives...


Best wishes,
Jia-Ju Bai