From: "Gustavo A. R. Silva" <gustavoars@kernel.org> Date: 2021-03-05 09:26:07
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/tipc/link.c | 1 +
1 file changed, 1 insertion(+)
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)break;caseLINK_FAILOVER_BEGIN_EVT:l->state=LINK_FAILINGOVER;+break;caseLINK_FAILURE_EVT:caseLINK_RESET_EVT:caseLINK_ESTABLISH_EVT:
From: Gustavo A. R. Silva <hidden> Date: 2021-04-20 20:09:42
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:25, Gustavo A. R. Silva wrote:
quoted hunk
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/tipc/link.c | 1 +
1 file changed, 1 insertion(+)
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)break;caseLINK_FAILOVER_BEGIN_EVT:l->state=LINK_FAILINGOVER;+break;caseLINK_FAILURE_EVT:caseLINK_RESET_EVT:caseLINK_ESTABLISH_EVT:
This patch looks good to me.
-----Original Message-----
From: Gustavo A. R. Silva <gustavoars@kernel.org>
Sent: Friday, March 5, 2021 5:25 PM
To: Jon Maloy <jmaloy@redhat.com>; Xue, Ying <redacted>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>; linux-hardening@vger.kernel.org
Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/tipc/link.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644--- a/net/tipc/link.c+++ b/net/tipc/link.c
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)break;caseLINK_FAILOVER_BEGIN_EVT:l->state=LINK_FAILINGOVER;+break;caseLINK_FAILURE_EVT:caseLINK_RESET_EVT:caseLINK_ESTABLISH_EVT:--
This patch looks good to me.
-----Original Message-----
From: Gustavo A. R. Silva <gustavoars@kernel.org>
Sent: Friday, March 5, 2021 5:25 PM
To: Jon Maloy <jmaloy@redhat.com>; Xue, Ying <redacted>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>; linux-hardening@vger.kernel.org
Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/tipc/link.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644--- a/net/tipc/link.c+++ b/net/tipc/link.c
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)break;caseLINK_FAILOVER_BEGIN_EVT:l->state=LINK_FAILINGOVER;+break;caseLINK_FAILURE_EVT:caseLINK_RESET_EVT:caseLINK_ESTABLISH_EVT:--