Thread (7 messages) 7 messages, 2 authors, 2021-03-01

Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held()

flat view

From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-03-01 08:29:29
Also in: linux-wireless, lkml

On Fri, Feb 26, 2021 at 02:16:12PM -0700, Shuah Khan wrote:
On 2/26/21 2:07 PM, Peter Zijlstra wrote:
quoted
On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote:
quoted
+		/* avoid false negative lockdep_assert_not_held()
+		 * and lockdep_assert_held()
+		 */
That's a coding style fail.
Checkpatch didn't complain.
  Documentation/CodingStyle

(or whatever unreadable rst crap it is today :-( )

and:

  https://lkml.kernel.org/lkml/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com/
What's your preference? Does the following work for you?

/*
 * avoid false negative lockdep_assert_not_held()
 * and lockdep_assert_held()
 */
Yep (ideally even with a Capital and full stop).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help