Re: [PATCH net-next] net: fix icmp_echo_enable_probe sysctl
flat view
From: Eric Dumazet <hidden>
Date: 2021-03-30 21:10:27
On Tue, Mar 30, 2021 at 11:06 PM Eric Dumazet [off-list ref] wrote:
From: Eric Dumazet <redacted> sysctl_icmp_echo_enable_probe is an u8. ipv4_net_table entry should use .maxlen = sizeof(u8). .proc_handler = proc_dou8vec_minmax,
I should have added the following tag :
Fixes: f1b8fa9fa586 ("net: add sysctl for enabling RFC 8335 PROBE messages")
quoted hunk ↗ jump to hunk
Signed-off-by: Eric Dumazet <redacted> Cc: Andreas Roeseler <redacted> --- net/ipv4/sysctl_net_ipv4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index e3cb2d96b55e99f4322a99abb6a6da866dffcf4d..9199f507a005efc3f57ca0225d3898bfa5d01c53 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c@@ -601,9 +601,9 @@ static struct ctl_table ipv4_net_table[] = { { .procname = "icmp_echo_enable_probe", .data = &init_net.ipv4.sysctl_icmp_echo_enable_probe, - .maxlen = sizeof(int), + .maxlen = sizeof(u8), .mode = 0644, - .proc_handler = proc_dointvec_minmax, + .proc_handler = proc_dou8vec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE }, --2.31.0.291.g576ba9dcdaf-goog