Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages
From: Andreas Roeseler <hidden>
Date: 2021-03-29 18:34:31
On Sun, 2021-03-28 at 13:00 -0400, Willem de Bruijn wrote:
On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler [off-list ref] wrote:quoted
quoted
+ if (!ext_hdr || !iio) + goto send_mal_query; + if (ntohs(iio->extobj_hdr.length) <= sizeof(iio-quoted
extobj_hdr))+ goto send_mal_query; + ident_len = ntohs(iio->extobj_hdr.length) - sizeof(iio-quoted
extobj_hdr);As asked in v3: this can have negative overflow?
The line above checks that iio->extobj_hdr.length is greater than the size of iio->extobj_hdr.