On Mon, Mar 29, 2021 at 7:46 PM Jason Gunthorpe [off-list ref] wrote:

On Mon, Mar 29, 2021 at 07:01:44AM -0700, Michael Chan wrote:

quoted

On Mon, Mar 29, 2021 at 1:52 AM Leon Romanovsky [off-list ref] wrote:

quoted

From: Leon Romanovsky <leonro@nvidia.com>

There is no need in any indirection complexity for one ULP user,
remove all this complexity in favour of direct calls to the exported
symbols. This allows us to greatly simplify the code.

The goal is not to have a hard dependency between the RDMA driver and
the ethernet driver.  One day, there may be a newer ethernet driver
for newer devices.  The RDMA driver may be the same because it
operates at a higher level.  The hard dependency will require the
older ethernet driver to always be loaded even if it is not needed.

Then someday you will fix it. Today you do not have this, so it needs
to be deleted.

If you ever get to that point you will need to rework this driver to
use auxillary bus/etc, and it will look very different anyhow.

Jason

Hello Jason and Leon,

Thanks for the series, we will get back with an ACK on this series
after internal discussion to see if all the cases are covered and our
internal test harness is passing with these changes.


-- 
-Regards
Devesh