Thread (5 messages) flat view 5 messages, 5 authors, 2021-03-29

Re: [PATCH 1/1] net: dsa: Fix type was not set for devlink port

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-03-29 16:26:40

On Mon, Mar 29, 2021 at 06:30:16PM +0300, Maxim Kochetkov wrote:
If PHY is not available on DSA port (described at devicetree but absent or
failed to detect) then kernel prints warning after 3700 secs:

[ 3707.948771] ------------[ cut here ]------------
[ 3707.948784] Type was not set for devlink port.
[ 3707.948894] WARNING: CPU: 1 PID: 17 at net/core/devlink.c:8097 0xc083f9d8

We should unregister the devlink port as a user port and
re-register it as an unused port before executing "continue" in case of
dsa_port_setup error.

Fixes: 86f8b1c01a0a ("net: dsa: Do not make user port errors fatal")
Signed-off-by: Maxim Kochetkov <redacted>
---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help