Re: [PATCH v2 05/23] ice: Add devlink params support
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-03-29 16:08:57
Also in:
linux-rdma
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-03-29 16:08:57
Also in:
linux-rdma
On Thu, Mar 25, 2021 at 08:10:13PM +0000, Saleem, Shiraz wrote:
Maybe I am missing something but I see that a devlink hot reload is required to enforce the update? There isn't really a de-init required of PCI driver entities in this case for this rdma param. But only an unplug, plug of the auxdev with new value. Intuitively it feels more runtime-ish. There is also a device powerof2 requirement on the maxqp which I don't see enforceable as it stands. This is not super-critical for the initial submission but a nice to have. But I do want to brainstorm options..
devlink upai often seems to be an adventure, can you submit this driver without devlink (or any other uapis) then debate how to add them in as followup patches? Jason