Thread (11 messages) flat view 11 messages, 3 authors, 2021-03-26

Re: [PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-03-26 12:18:10

On Thu, Mar 25, 2021 at 07:07:24PM -0700, Jakub Kicinski wrote:
struct ethtool_fecparam::reserved is never looked at by the core.
Make sure it's actually 0. Unfortunately we can't return an error
because old ethtool doesn't zero-initialize the structure for SET.
On GET we can be more verbose, there are no in tree (ab)users.

Fix up the kdoc on the structure. Remove the mention of FEC
bypass. Seems like a niche thing to configure in the first
place.

v2: - also mention the zero-init-on-SET kerfuffle in kdoc

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help