Thread (13 messages) 13 messages, 3 authors, 2021-03-23

Re: [PATCH next-queue v3 1/3] Revert "PCI: Make pci_enable_ptm() private"

From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2021-03-23 18:41:19
Also in: intel-wired-lan, linux-pci

Christoph Hellwig [off-list ref] writes:
On Mon, Mar 22, 2021 at 09:18:20AM -0700, Vinicius Costa Gomes wrote:
quoted
Make pci_enable_ptm() accessible from the drivers.

Even if PTM still works on the platform I am using without calling
this function, it might be possible that it's not always the case.

Exposing this to the driver enables the driver to use the
'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.

This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.

Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Without an EXPORT_SYMBOL_GPL this is not going to be very useful for
your driver.
Unless I am missing something here, the commit that made
'pci_enable_ptm()' private didn't remove the 'EXPORT_SYMBOL' from the
function definition in drivers/pci/pcie/ptm.c.


Cheers,
-- 
Vinicius
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help