Re: [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB region

On Sun Mar 14 2021, Kurt Kanzenbach wrote:

On Sat Mar 13 2021, Vladimir Oltean wrote:

quoted

On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:

quoted

Allow to dump the FDB table via devlink. This is a useful debugging feature.

Signed-off-by: Kurt Kanzenbach <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

By the way, what user space program do you use to dump these? Did you
derive something from Andrew's mv88e6xxx_dump too? Maybe we should work
on something common?

Actually there is no user space tooling, yet. My original approach to
debugging was different using debugfs and tracing. I played a bit with
mv88e6xxx_dump today. Having a common tool would be quite nice.

Thanks for the pointer to mv88e6xxx_dump. Just needed to implement
.devlink_info_get() callback, so that the tool can distinguish between
the Marvell and Hellcreek devices (and implement some hellcreek
specifics).

Thanks,
Kurt