Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix

On 3/19/2021 12:47 PM, Marek Behún wrote:

On Fri, 19 Mar 2021 20:58:20 +0200
Vladimir Oltean [off-list ref] wrote:

quoted

On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote:

quoted

We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane`
to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE.

All other occurances in this function are using the `lane` variable.

It seems I forgot to change it at this one place after refactoring.

Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: de776d0d316f7 ("net: dsa: mv88e6xxx: add support for ...")
---  

Either do the Fixes tag according to the documented convention:
git show de776d0d316f7 --pretty=fixes

THX, did not know about this.

quoted

Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")

or even better, drop it.

Why better to drop it?

To differentiate an essential/functional fix from a cosmetic fix. If all
cosmetic fixes got Fixes: tag that would get out of hands quickly.
-- 
Florian