Thread (15 messages) flat view 15 messages, 2 authors, 2021-03-18

Re: [PATCH net-next v4 00/13] net: xps: improve the xps maps handling

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-03-18 23:11:17

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Thu, 18 Mar 2021 19:37:39 +0100 you wrote:
Hello,

This series aims at fixing various issues with the xps code, including
out-of-bound accesses and use-after-free. While doing so we try to
improve the xps code maintainability and readability.

The main change is moving dev->num_tc and dev->nr_ids in the xps maps, to
avoid out-of-bound accesses as those two fields can be updated after the
maps have been allocated. This allows further reworks, to improve the
xps code readability and allow to stop taking the rtnl lock when
reading the maps in sysfs. The maps are moved to an array in net_device,
which simplifies the code a lot.

[...]
Here is the summary with links:
  - [net-next,v4,01/13] net-sysfs: convert xps_cpus_show to bitmap_zalloc
    https://git.kernel.org/netdev/net-next/c/ea4fe7e842f6
  - [net-next,v4,02/13] net-sysfs: store the return of get_netdev_queue_index in an unsigned int
    https://git.kernel.org/netdev/net-next/c/d9a063d207f0
  - [net-next,v4,03/13] net-sysfs: make xps_cpus_show and xps_rxqs_show consistent
    https://git.kernel.org/netdev/net-next/c/73f5e52b15e3
  - [net-next,v4,04/13] net: embed num_tc in the xps maps
    https://git.kernel.org/netdev/net-next/c/255c04a87f43
  - [net-next,v4,05/13] net: embed nr_ids in the xps maps
    https://git.kernel.org/netdev/net-next/c/5478fcd0f483
  - [net-next,v4,06/13] net: remove the xps possible_mask
    https://git.kernel.org/netdev/net-next/c/6f36158e0584
  - [net-next,v4,07/13] net: move the xps maps to an array
    https://git.kernel.org/netdev/net-next/c/044ab86d431b
  - [net-next,v4,08/13] net: add an helper to copy xps maps to the new dev_maps
    https://git.kernel.org/netdev/net-next/c/402fbb992e13
  - [net-next,v4,09/13] net: improve queue removal readability in __netif_set_xps_queue
    https://git.kernel.org/netdev/net-next/c/132f743b01b8
  - [net-next,v4,10/13] net-sysfs: move the rtnl unlock up in the xps show helpers
    https://git.kernel.org/netdev/net-next/c/d7be87a687cc
  - [net-next,v4,11/13] net-sysfs: move the xps cpus/rxqs retrieval in a common function
    https://git.kernel.org/netdev/net-next/c/2db6cdaebac8
  - [net-next,v4,12/13] net: fix use after free in xps
    https://git.kernel.org/netdev/net-next/c/2d05bf015308
  - [net-next,v4,13/13] net: NULL the old xps map entries when freeing them
    https://git.kernel.org/netdev/net-next/c/75b2758abc35

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help