Re: [PATCH net-next] net: add a helper to avoid issues with HW TX timestamping and SO_TXTIME

Hi Po,

On Thu, Mar 11, 2021 at 02:30:12AM +0000, Po Liu wrote:

Hi

Can it just move

 skb->tstamp = ktime_set(0, 0);

into

skb_tstamp_tx(skb, &shhwtstamps);

if it always need to clear for HW tstamp setting.

I don't know if that works under all circumstances. Also, to keep the
driver interface consistent, we would also need to plug that into
skb_complete_tx_timestamp, for the case when the driver is working with
a clone directly.
It just seemed simpler to me to modify the few drivers which use SO_TXTIME.