Re: [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed up s2ram

Hi Jakub,
thanks for taking a look!
On Mon, Mar 15, 2021 at 02:04:22PM -0700, Jakub Kicinski wrote:

On Mon, 15 Mar 2021 12:02:30 -0700 Tony Nguyen wrote:

quoted

+static __maybe_unused int e1000e_pm_prepare(struct device *dev)
+{
+	return pm_runtime_suspended(dev) &&
+		pm_suspend_via_firmware();

nit: I don't think you need to mark functions called by __maybe_unused
     as __maybe_unused, do you?

Not sure which function do you refer to having the __maybe_unused attribute
and invokes this e1000e_pm_prepare()?
I copied the definition from e1000e_pm_suspend() that if CONFIG_PM_SLEEP is not
set, we might get compile error of such PM hooks in this driver.

The series LGTM although I don't know much about PM.

Thanks!

Best,
Chenyu