Thread (2 messages) flat view 2 messages, 2 authors, 2021-03-12

Re: [PATCH net] mptcp: fix bit MPTCP_PUSH_PENDING tests

From: Matthieu Baerts <hidden>
Date: 2021-03-12 08:12:29
Also in: kernel-janitors, mptcp

Hi Dan,

On 12/03/2021 08:41, Dan Carpenter wrote:
The MPTCP_PUSH_PENDING define is 6 and these tests should be testing if
BIT(6) is set.
Good catch, indeed, BIT() macro is missing!

It was not detected by our tests suite because in -net, that's the only 
flag that is set.

But another patch for net-next is coming and another flag can be set as 
well. What's funny is that this other flag is "9" which works well with 
"6" because their bits are not overlapping :)
Anyway, better with "BIT()" macro!

Reviewed-by: Matthieu Baerts <redacted>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help