Thread (5 messages) flat view 5 messages, 4 authors, 2021-03-10

Re: [PATCH net-next] net: add a helper to avoid issues with HW TX timestamping and SO_TXTIME

From: Richard Cochran <richardcochran@gmail.com>
Date: 2021-03-10 16:32:19

On Wed, Mar 10, 2021 at 04:50:44PM +0200, Vladimir Oltean wrote:
As explained in commit 29d98f54a4fe ("net: enetc: allow hardware
timestamping on TX queues with tc-etf enabled"), hardware TX
timestamping requires an skb with skb->tstamp = 0. When a packet is sent
with SO_TXTIME, the skb->skb_mstamp_ns corrupts the value of skb->tstamp,
so the drivers need to explicitly reset skb->tstamp to zero after
consuming the TX time.

Create a helper named skb_txtime_consumed() which does just that. All
Bikeshedding about the name: "consumed" suggests much more to me than
what is going on.

How about this?   skb_reset_txtime();

Thanks,
Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help