Thread (4 messages) flat view 4 messages, 3 authors, 2021-03-10

Re: [PATCH net] net: dsa: only unset VLAN filtering when last port leaves last VLAN-aware bridge

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-03-09 08:58:03

On Tue, Mar 09, 2021 at 07:31:25AM +0100, Kurt Kanzenbach wrote:
quoted
@@ -124,13 +124,16 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds,
 	 * it. That is a good thing, because that lets us handle it and also
 	 * handle the case where the switch's vlan_filtering setting is global
 	 * (not per port). When that happens, the correct moment to trigger the
-	 * vlan_filtering callback is only when the last port left this bridge.
+	 * vlan_filtering callback is only when the last port the last
Somehow "left" got missing. Shouldn't that line be:

"vlan_filtering callback is only when the last port left the last" ?
Thanks, you're right, I don't know how it happened, I'll resend.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help