Thread (3 messages) 3 messages, 3 authors, 2021-02-24

Re: [PATCH net] selftest/bpf: no need to drop the packet when there is no geneve opt

From: William Tu <hidden>
Date: 2021-02-24 19:19:00
Also in: bpf

On Wed, Feb 24, 2021 at 12:37 AM Hangbin Liu [off-list ref] wrote:
In bpf geneve tunnel test we set geneve option on tx side. On rx side we
only call bpf_skb_get_tunnel_opt(). Since commit 9c2e14b48119 ("ip_tunnels:
Set tunnel option flag when tunnel metadata is present") geneve_rx() will
not add TUNNEL_GENEVE_OPT flag if there is no geneve option, which cause
bpf_skb_get_tunnel_opt() return ENOENT and _geneve_get_tunnel() in
test_tunnel_kern.c drop the packet.

As it should be valid that bpf_skb_get_tunnel_opt() return error when
there is not tunnel option, there is no need to drop the packet and
break all geneve rx traffic. Just set opt_class to 0 in this test and
keep returning TC_ACT_OK.

Signed-off-by: Hangbin Liu <redacted>
---
LGTM.
Acked-by: William Tu <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help